Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Notification not showing #30

Closed
DwieDave opened this issue Jul 7, 2022 · 8 comments
Closed

Fullscreen Notification not showing #30

DwieDave opened this issue Jul 7, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@DwieDave
Copy link

DwieDave commented Jul 7, 2022

Hi,

i've updated my Model 3 to 2022.16.3 today and wanted to test the browser performance with testube but the Fullscreen toast notification did not show up and therefore apps like A better Routeplanner did not load in Fullscreen.

Is there a known bug at the moment?

Regards

@JaxonWright
Copy link
Member

Hello @DwieDave,

Could you please:

  1. Click on the build hash in the bottom middle of the screen. (Where the fullscreen notification usually is)
    image

  2. Click the copy button on the end of the UserAgent field, and paste it in here?
    image

I am on the FSD beta, so I can only go make sure it works on my software and its hard to test other configs without knowing that information.

Thanks

@JaxonWright JaxonWright added bug Something isn't working question Further information is requested labels Jul 11, 2022
@JaxonWright
Copy link
Member

Related to #27

@DwieDave
Copy link
Author

DwieDave commented Jul 11, 2022

The build shown is from June 20
(Hash fafc18a)
I really dont know how to paste from the tesla (is it even possible?)

I've taken a picture and used OCR:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 Tesla/feature-2022.16.3-391-cedf22462e

EDIT:
The regex pattern you used in the app.component.ts is not matching with my userAgent String and therefore not showing the SnackBar.

This regex would match my userAgent as well:
Tesla\/(develop-)*(feature-)*(?:.*fsd.*)*([0-9]{4}.[0-9]{1,3}.?[0-9]{0,3}.?[0-9]{0,3}.?[0-9]{0,3})*-(.*)

@JaxonWright
Copy link
Member

JaxonWright commented Jul 11, 2022

I really dont know how to paste from the tesla (is it even possible?)

I think you can just long-press in a text area. I guess I should try it before telling people to do it haha.

Thanks for going above and beyond. I'll look into fixing it tonight! They keep adding words to the string, making it hard to account for everything. Your new RegEx should work well upon just glancing at it.

@JaxonWright JaxonWright removed the question Further information is requested label Jul 11, 2022
@JaxonWright JaxonWright self-assigned this Jul 11, 2022
@DwieDave
Copy link
Author

I've tried the iOS tap and hold gesture in every possible way and nothing showed up.
Thanks for the fast reply.

Just out of curiosity: Why do you show the SnackBar only in a Tesla Browser?

@JaxonWright
Copy link
Member

I've tried the iOS tap and hold gesture in every possible way and nothing showed up.

OK, I'll have to think of a different way for people to report this kind of info, then :\

Just out of curiosity: Why do you show the SnackBar only in a Tesla Browser?

Because that is the only browser that the action actually does anything on. I also need to detect the Tesla browser to apply some scaling to the site that reverses something that Tesla does to every site in their browser when in Theater Mode. They apply a zoom to it that was messing with things in fullscreen.

@JaxonWright
Copy link
Member

@DwieDave fixed now. Thanks again for the help!

@DwieDave
Copy link
Author

Thanks for your fast update!
The Snackbar is now showing and fullscreen mode is working but now I have another bug (issue #33).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants