New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide some basic template variable expansion? #53
Comments
Considering that you have all the meta-data already in https://github.com/arbourd/concourse-slack-alert-resource/blob/master/concourse/build.go#L42 this seems to be an easy job. sure we jsut should use gotemplate for the template langauge |
When I first conceived this resource, I never really wanted (or considered) templating. It's a possibility but it's a large overhaul at the moment. I think one way this can be solved in the future is with #36 to allow custom messages to be set. |
Well setting the message by file and using template placeholders are not the same thing, but for sure expanding templates which are from files the same way would make sense. So i would say that those are 2 entirely different features which may though be enriched by this, being it a normal string message or a file based one |
Maybe if we only exposed the |
@EugenMayer Where would you want these custom links anyways? They already exist in the footer. |
I'm assuming for the time being that you wanted this because of Mattermost, but the link does exist for Slack at the current time. I'm going to close this for now unless there is another reason why we might want those variables. |
Thanks for coming back to this, but since i forked of, i did not want to invest here, someone lese should so it makes sense for you to put work into that. I assume that it is the right call to let it where it is until someone else need it, which i entirely cannot understand i this should not be the case ( IMHO ). Thanks |
Like in the hipchat or other slack resources ( cloudfoundry ) there are usually some interesting variables you would like to see expaneded in the message.
One could construct custom links like
/teams/$BUILD_TEAM_NAME/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME
What do you think? Thanks
The text was updated successfully, but these errors were encountered: