Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab backend needs to do error handling #42

Open
plajjan opened this issue Apr 3, 2018 · 0 comments
Open

GitLab backend needs to do error handling #42

plajjan opened this issue Apr 3, 2018 · 0 comments
Labels
enhancement This is new functionality or enhancement to existing functionality gitlab Related to the github backend

Comments

@plajjan
Copy link
Collaborator

plajjan commented Apr 3, 2018

When I ran into #41 but before I knew what caused it all I got from Emacs/org-sync was:
helm-M-x: JSON readtable error which isn't particularly helpful at all. I think it originates from this

(json-read)

As I wrote in #41, we're actually getting a 414 error back from the server, so how about we check the HTTP status code before we try to JSON parse the message? It should always be 200 OK I guess or we can throw an error (but about the HTTP status code and not JSON!!)

@plajjan plajjan added enhancement This is new functionality or enhancement to existing functionality gitlab Related to the github backend labels Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is new functionality or enhancement to existing functionality gitlab Related to the github backend
Projects
None yet
Development

No branches or pull requests

1 participant