Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Fix modals #999

Closed
2 tasks done
dartpain opened this issue Jun 19, 2024 · 0 comments · Fixed by #1005
Closed
2 tasks done

🐛 Bug Report: Fix modals #999

dartpain opened this issue Jun 19, 2024 · 0 comments · Fixed by #1005
Assignees
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@dartpain
Copy link
Contributor

📜 Description

Improve modals and sidebar.
Make sure that if user clicks outside of the modal it closes
Make sure that if user clicks outside sidebar on mobile it closes

👟 Reproduction steps

  1. Click on modal
  2. Click outside modal

👍 Expected behavior

  1. Click on modal
  2. Click outside modal -> modal closes

👎 Actual Behavior with Screenshots

Modal does not close
Side bar does not close on mobile

💻 Operating system

MacOS

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

🤖 What development environment are you experiencing this bug on?

Docker

🔒 Did you set the correct environment variables in the right path? List the environment variable names (not values please!)

No response

📃 Provide any additional context for the Bug.

No response

📖 Relevant log output

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🔗 Are you willing to submit PR?

None

🧑‍⚖️ Code of Conduct

  • I agree to follow this project's Code of Conduct
@dartpain dartpain added good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code frontend labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants