Potential pull request

[attebury]

I've forked your project and am using a few grunt plugins to create PNG fallbacks and am experimenting with the creation of league webfonts. It's still a work in progress, but I'm getting close to decision points and your input would help.

Is this something you'd be interested in merging back into this project or should I just plan to keep those changes in a separate fork?

If you'd prefer to keep it separate, I have minified the SVGs and can contribute those back if helpful

.

[jimniels]

To be honest, I haven't familiarized myself with Grunt yet, so all I see is a bunch of complexity I don't understand ha ;) Although I'm curious … creating a webfont out of the team logos would make them all single color no?

I think for right now, keeping your work as a separate fork would be good, as I'm not familiar with grunt and would still like to tweak and manage this site myself. Right now the process for adding/removing/tweaking teams is really simple. Add the team colors in the .json file and add a logo (SVG is possible, if none, a PNG). PNG fallbacks for all teams (in sprite format) would likely be ideal, so I like this direction, but I don't think I'm ready to incorporate grunt into this project quite yet.

The minified SVGs would be helpful though, as I didn't do any work in optimizing those assets.

[attebury]

No worries. I'l add the minified files.

I've created an Illustrator file with each logo on its own artboard. (Following the Filament Group's workflow.

Would you be interested in that file?

[jimniels]

Cool, minified SVGs would be great.

I don't see an immediate need for the illustrator file in the site's current workflow, but I think I'd still like to have it as it may become very handy in the future.

Thanks!

[attebury]

Here's the ai.

I resized logos so that their proportions matched.

This also contains black & white version which I've used in my font experiments, but more work needs to be done on some of the inidividual SVGs. But you can of course just delete those.

[jimniels]

This is very cool. Thanks for adjusting the proportions accordingly, so they look unified. Are you doing this with all the leagues?

[mattq]

Just chiming in to mention that this is an older version of the Vikings logo. Guessing that should be a separate issue altogether @jimniels?

[attebury]

Thanks! As time allows I would eventually do this for all of the leagues. (Having others contribute to that effort was one reason I wanted to contribute the .ai file back to the project.)

[attebury]

You mentioned that you'd like the minified SVGs. Should I just commit those into the appropriate img directory?

[jimniels]

Yeah, I see no reason to keep the larger file sizes if you've got smaller ones. Thanks!

[attebury]

As I continue forking teamcolors I'll contribute back anything that will work with your workflow. I

I'll also credit the original repo of course. Once I'm further along I'll contact you to see how you'd like attribution.

I'll close this issue.

[jimniels]

Note: the repo is now running on Gulp.