Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transaction History #33

Closed
lokka30 opened this issue Oct 12, 2021 · 3 comments
Closed

Add Transaction History #33

lokka30 opened this issue Oct 12, 2021 · 3 comments
Assignees
Labels
priority: normal Normal priority status: confirmed Approved / validated status: on hold Development is paused until further notice type: improvement A feature is added or adjusted
Projects

Comments

@lokka30
Copy link
Member

lokka30 commented Oct 12, 2021

@MrNemo64 suggested the following method: public Collection<BankTransactionEntry> getTransactionHistory() { ... }

Will expand on this issue later. If anyone has thoughts on this issue please drop them below :)

@lokka30 lokka30 added type: improvement A feature is added or adjusted priority: normal Normal priority thoughts wanted Thoughts from other developers would be appreciated on this issue. status: confirmed Approved / validated labels Oct 12, 2021
@lokka30 lokka30 self-assigned this Oct 12, 2021
@lokka30 lokka30 added this to To do in v1.0 via automation Oct 12, 2021
@lokka30 lokka30 changed the title Transaction History Add Transaction History Oct 15, 2021
@lokka30
Copy link
Member Author

lokka30 commented Oct 26, 2021

Methods:

  • In the Account interface: public Collection<BankTransaction> getTransactionHistory()
  • In the EconomyProvider interface: public boolean hasTransactionHistorySupport()

Of course the first method mentioned will be changed to suit #37.

@lokka30 lokka30 removed the thoughts wanted Thoughts from other developers would be appreciated on this issue. label Oct 26, 2021
@MrNemo64
Copy link
Contributor

MrNemo64 commented Dec 7, 2021

While working on #31 I realized that depending on the structure of the BankTransaction we may have to change some things. If, for example, the BankTransaction holds a player and the amount that they withdraw/deposit then the withdrawBalance and depositBalance from the Account interface may also need to have an UUID player param so we can register who withdraws/deposits. There are some other methods that may need to change but these 2 are the first ones that come to my mind

@lokka30
Copy link
Member Author

lokka30 commented Dec 8, 2021

While working on #31 I realized that depending on the structure of the BankTransaction we may have to change some things. If, for example, the BankTransaction holds a player and the amount that they withdraw/deposit then the withdrawBalance and depositBalance from the Account interface may also need to have an UUID player param so we can register who withdraws/deposits. There are some other methods that may need to change but these 2 are the first ones that come to my mind

What if there is no player involved in the transaction?
For multiple players involved I think separate transactions would be fine.

@MrIvanPlays MrIvanPlays added the status: on hold Development is paused until further notice label Dec 10, 2021
v1.0 automation moved this from To do to Done Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Normal priority status: confirmed Approved / validated status: on hold Development is paused until further notice type: improvement A feature is added or adjusted
Projects
No open projects
v1.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants