Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Config Object Copy #3

Closed
arcanus55 opened this issue Dec 27, 2021 · 2 comments
Closed

Custom Config Object Copy #3

arcanus55 opened this issue Dec 27, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@arcanus55
Copy link
Owner

The custom config object should allow for a subset of the library config object. The transfer from custom should be on a per properties basis. Currently all properties must exist in the custom object, however it should work if only one exists.

@neodigm neodigm added the good first issue Good for newcomers label Jan 7, 2022
@neodigm
Copy link
Collaborator

neodigm commented Jan 15, 2022

The current solutions works so this is really just a "nice to have".

@neodigm
Copy link
Collaborator

neodigm commented Jan 24, 2022

This is fixed in v1.8.0.

Usage:
Create a custom config snippet before loading the N55 JS.
<script> let neodigmOptCustom = {} neodigmOptCustom.neodigmWired4Sound_EVENTS = false; </script>
Opening a Soda Pop should make no sound, however executing a neodigmWired4Sound.play( x ), should make a sound.
This is done to give implementers the ability to stop ambient sounds without disabling all audio.

@neodigm neodigm closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants