Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeodigmMetronome | Move native timeout and interval functions to a separate thread. #51

Closed
neodigm opened this issue Mar 25, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request performance Make faster v3.0 Target version 3.0

Comments

@neodigm
Copy link
Collaborator

neodigm commented Mar 25, 2023

Improve performance by overloading the setTimeout and setInterval with a multi-threaded implementation.

@neodigm neodigm added enhancement New feature or request performance Make faster labels Mar 25, 2023
@neodigm neodigm self-assigned this Mar 25, 2023
@arcanus55
Copy link
Owner

Behind a feature flag. I imagine, off by default?

@neodigm
Copy link
Collaborator Author

neodigm commented Mar 25, 2023

This is complete in v2.5. This logic has been integrated into the NeodigmMetronome init method.

Usage: Turn on feature flag.

<script>
let neodigmOptCustom = {  neodigmWWInterval:true }
</script>

@neodigm neodigm closed this as completed Mar 25, 2023
@neodigm
Copy link
Collaborator Author

neodigm commented Mar 30, 2023

Reconsider this. Perhaps make it N55 specific. Meaning, conditionally use setTimeoutN55() within the N55 components. This would negate compatibility risks.

@neodigm neodigm reopened this Mar 30, 2023
@neodigm neodigm added the v3.0 Target version 3.0 label Aug 23, 2023
@neodigm
Copy link
Collaborator Author

neodigm commented Aug 31, 2023

Update: Turning on Feature Flag, however the components that make use of it will be limited.
Using the setTimeoutN55() idea and it seems to work.
Adding some debug level logging.
Documentation, will be just a comment in the architecture overview.

@neodigm
Copy link
Collaborator Author

neodigm commented Aug 31, 2023

This issue is resolved in v3.0 (Toast Only - setTimeout Only)
Feature flag is true by default

<script>
// Turn on Feature Flag
// Turn  on debugger to verify | neodigmOpt.N55_DEBUG_lOG = true 
let neodigmOptCustom = {  neodigmWWInterval:true }
// Verify by neodigmToast.q("If this Toast goes away, it is working", "brand")
</script>

@neodigm neodigm closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Make faster v3.0 Target version 3.0
Projects
None yet
Development

No branches or pull requests

2 participants