Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neodigm Marque | Calling init seams to speed up the display #83

Closed
neodigm opened this issue Sep 7, 2023 · 2 comments
Closed

Neodigm Marque | Calling init seams to speed up the display #83

neodigm opened this issue Sep 7, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@neodigm
Copy link
Collaborator

neodigm commented Sep 7, 2023

Might need a better handshake with neodigmmetrnome, to unregister.

To reproduce just exec neodigmMarquee.init() many times on any page with a marquee instance.
@neodigm neodigm added bug Something isn't working good first issue Good for newcomers labels Sep 7, 2023
@neodigm
Copy link
Collaborator Author

neodigm commented Sep 8, 2023

Lets look at moving Metronome to worklet.

@neodigm
Copy link
Collaborator Author

neodigm commented Dec 25, 2023

This issue is resolved in v3.1. The solution was to add safety logic on the NeodigmMetronome.subscribe method, rejecting deplicate "uniqueDuration" values.

@neodigm neodigm closed this as completed Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neodigm