Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Scryfall bulk data files #44

Closed
iambroadband opened this issue Aug 4, 2023 · 4 comments · Fixed by #104
Closed

Setup Scryfall bulk data files #44

iambroadband opened this issue Aug 4, 2023 · 4 comments · Fixed by #104
Assignees

Comments

@iambroadband
Copy link
Contributor

Description

This behavior used to be supported in Ophidian, but now it needs to be supported in scooze. We should support:

  • Oracle Cards
  • Default Cards
  • All Cards

You may want to have some constants in utils or similar for data directories to download these files to. You can add flags to the CLI to download these files as part of this ticket if you want. Make sure to exclude the download directory from git in .gitignore.

Resources

https://scryfall.com/docs/api/bulk-data

@fjork3 fjork3 self-assigned this Aug 4, 2023
@iambroadband iambroadband added this to the Bulk File Support milestone Aug 11, 2023
@JacobGinsparg
Copy link
Contributor

@fjork3 can you fix the relative import here before you close this issue: https://github.com/arcavios/scooze/blob/dev/src/scooze/bulkdata.py#L54

I think eventually we'll get rid of this and just have the CLI handle the path but for now if you run it top level it'll be in a weird spot.

@fjork3
Copy link
Contributor

fjork3 commented Aug 24, 2023

Just gonna remove that piece entirely; was using it during testing but we don't need to have bulkdata be a runnable file at all.

@iambroadband
Copy link
Contributor Author

Is this ticket considered complete?

@fjork3
Copy link
Contributor

fjork3 commented Aug 31, 2023

The download portion is working, but I'm not sure I'd say they're fully supported until #40 is complete and we can actually load them to DB.

@fjork3 fjork3 linked a pull request Sep 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants