Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoRA #300

Closed
Tengal-Teemo opened this issue May 1, 2024 · 1 comment
Closed

DoRA #300

Tengal-Teemo opened this issue May 1, 2024 · 1 comment

Comments

@Tengal-Teemo
Copy link

Hi everyone. I've been testing out mergekit recently, and I'm amazed by it. I was investigating the performance discrepancy between LoRA and Finetune, and came across this paper, proposing DoRA. Would it be possible for mergekit, alongside LoRA extraction, to implement DoRA extraction?

@thomasgauthier
Copy link
Contributor

@Tengal-Teemo DoRA is beneficial during training as it more closely resembles the updates done during full finetuning (see Figure 2 of the paper). In other words it is more likely than LoRA to converge at the same rate as a full FT. I don't think however that it would be useful in a post-training context like LoRA extraction as all the weights updates and convergence have already happened. Closing this for now as DoRA extraction is not a planned feature.

Happy to keep the discussion going however if anyone disagrees with the above points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants