[Feature Request] Fill Colour for relationship text

[alcedocoenen]

Using lots of relationship names, it is disturbing that the arrow is crossing the text (when positioned middle), making the text less readable. The text-box is transparant by default, and this is not changeable.

It would be nice of we also could define the Fill Colour for the relationship text. The colour by default, I would say, should be white:

What do you think?

[Phillipus]

Yes, this is possible. Also better would be multi-line text and free positioning of the text label rather than the limited three positions currently implemented. I can implement the first two but not the free positioning - this requires better GEF/Draw2d expertise than I currently have. Perhaps that would be something that someone in the OS community might try.

[jbsarrodie]

Hi,

I have a small patch to add this background (in fact I created it more than a year ago). It only miss some options (and obsiously to adapt ecore model to store the color). I can confrm this has been prooven useful.

Multi-line would be useful too.

[jbsarrodie]

I'm working on it. My current approach is to not draw the part of the relationship under the label. This would remove the need to set an explicit background.

[Phillipus]

Set opacity of label?

[Phillipus]

Surely a simple fix is in AbstractDiagramConnectionFigure:

    public Label getConnectionLabel() {
        if(fConnectionLabel == null) {
            fConnectionLabel = new Label(""); //$NON-NLS-1$
            fConnectionLabel.setOpaque(true); // <------- ADD THIS LINE!
            add(fConnectionLabel);
        }
        return fConnectionLabel;
    }

[jbsarrodie]

I have to test. This seems very similar in effect.

[Phillipus]

I guess the problem with setting it to opaque is this:

[Phillipus]

But then if we add opacity value or fill color the user could adjust as needed

[jbsarrodie]

OK, that's why I did it differetly. Look at the branch I pushed yesterday. This is a test that works great. I should be able to optimize it through a better clipping area.

[Phillipus]

But maybe if the user has options of (1) Opacity and (2) Fill color it provides them with more choice? Perhaps they would like a white label on a grey background?

[jbsarrodie]

In this context I'm all for the KISS principle. IMHO our real issue is that label is not readable when set in the middle, not that someone misses label background.

[jbsarrodie]

@Phillipus I've just re-pushed my branch with my "final" fix. You can test it and merge it if ok for you.

[Phillipus]

@jbsarrodie Yeah, that seems to do the trick. I guess we should merge it and see what users think. If there are any problems with it we can either tweak it, remove it, add an opacity/fill option....

[janwilmans]

I'm curious to test this too, I have this also:

in a grey-folder background making it hard to read. I will try the head version to test

[jbsarrodie]

Closing as this has been fixed for some time