Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line jump curves not working in some cases #311

Closed
Phillipus opened this issue Nov 6, 2017 · 10 comments
Closed

Line jump curves not working in some cases #311

Phillipus opened this issue Nov 6, 2017 · 10 comments

Comments

@Phillipus
Copy link
Member

Archi 4.0.3, Windows and Mac

See http://forum.archimatetool.com/index.php?topic=451.msg2498

@Phillipus
Copy link
Member Author

Example:

image

@Phillipus
Copy link
Member Author

test.archimate file:

test.zip

@Phillipus
Copy link
Member Author

Might be an issue to do with connection to connection in com.archimatetool.editor.diagram.figures.connections.RoundedPolylineConnection

@jbsarrodie ?

@jbsarrodie
Copy link
Member

Hi,

I'll have a look at it. Should be easy to fix.

@Phillipus
Copy link
Member Author

Should be easy to fix.

🤣

@jbsarrodie
Copy link
Member

Was easy. See new linejump-fix branch :-)

TBH the root cause lies in OrthogonalAnchor that has to be adapted for connection-to-connection (now on my todo), but the point comparison method was too strict anyway.

@Phillipus
Copy link
Member Author

Was easy.

Nooooooo!!!!!

Merged ;-)

@Phillipus Phillipus added this to Done & To Be Reviewed in Archi 4.1.0 Release Nov 8, 2017
@jbsarrodie
Copy link
Member

Merged ;-)

Well.... I haven't had time to do in depth tests, so we might have some side effects (who knows....)

@Phillipus
Copy link
Member Author

That's why we have betas...

@Phillipus
Copy link
Member Author

In 4.1.0

@Phillipus Phillipus moved this from Done & To Be Reviewed to Closed in Archi 4.1.0 Release Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants