Generate View For Elements - "Add all available connections" mystery option

[Phillipus]

When using the "Generate View For..." feature selecting "Add all available connections" doesn't seem to do anything.

These are the line in the code (GenerateViewCommand.java):

// Don't add connections that are not connected to the main elements if option is set
if(!fAddAllConnections && !(fSelectedElements.contains(elementSource)) && !(fSelectedElements.contains(elementTarget))) {
   continue;
}

There might be a mistake in that one line so it should be:

if(!fAddAllConnections && !(fSelectedElements.contains(elementSource) && fSelectedElements.contains(elementTarget)))

But, to be honest, I can't remember why we would want such an option. Maybe it could be removed.

See https://forum.archimatetool.com/index.php?topic=799

[Phillipus]

It does do something if you select different elements for the "Generate View" command.

For example, given this:

If you select elements A and D and do a "Generate View" with the option deselected you get:

If you select elements A and D with the option selected you get:

[jbsarrodie]

I don't understand because:

1. I sometime use this option
2. As far as I can tell, it works

[Phillipus]

@jbsarrodie Yes, it does. I just couldn't remember...

[jbsarrodie]

When in doubt, ask an Archi user you know ;-)

[Phillipus]