fixing interpolation if a service config string has a -- in it #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-missing-graph-edges
tjhiggins
reviewed
Jul 7, 2022
| @@ -20,6 +20,7 @@ export default class SecretsDownload extends BaseCommand { | |||
| }; | |||
|
|
|||
| static args = [{ | |||
| non_sensitive: true, | |||
There was a problem hiding this comment.
What are non_sensitive secrets?
There was a problem hiding this comment.
nvm I see this is used everywhere now
There was a problem hiding this comment.
Isn't this just the secrets filename? That doesn't seem secret to me
tjhiggins
reviewed
Jul 7, 2022
| @@ -15,7 +15,7 @@ export class Slugs { | |||
|
|
|||
| public static ArchitectSlugDescription = `must contain only lower alphanumeric and single hyphens or underscores in the middle; max length ${Slugs.SLUG_CHAR_LIMIT}`; | |||
| static CharacterCountLookahead = `(?=.{1,${Slugs.SLUG_CHAR_LIMIT}}(\\${Slugs.NAMESPACE_DELIMITER}|${Slugs.TAG_DELIMITER}|$))`; | |||
| public static ArchitectSlugRegexBase = `(?!-)(?!.*--)[a-z0-9-]{1,${Slugs.SLUG_CHAR_LIMIT}}(?<!-)`; | |||
| public static ArchitectSlugRegexBase = `(?!-)(?!.{0,${Slugs.SLUG_CHAR_LIMIT}}--)[a-z0-9-]{1,${Slugs.SLUG_CHAR_LIMIT}}(?<!-)`; | |||
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
# [1.18.0-rc.5](v1.18.0-rc.4...v1.18.0-rc.5) (2022-07-07) ### Bug Fixes * **interpolation:** fixing interpolation if a service config string has a -- in it ([#610](#610)) ([7fc8458](7fc8458))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
# [1.18.0](v1.17.2...v1.18.0) (2022-07-08) ### Bug Fixes * **context:** including error if context doesn't exist and test updates ([#589](#589)) ([adf6f88](adf6f88)) * **interpolation:** fixing interpolation if a service config string has a -- in it ([#610](#610)) ([7fc8458](7fc8458)) * **k8s:** Support k8s 1.24+ ([#608](#608)) ([cfed071](cfed071)) ### Features * **error:** Add sentry error logging ([603ea01](603ea01)) * **platform:** Warn user about unsupported version of Kubernetes. ([3f6b702](3f6b702)) * **register:** Specify which architectures to build for your containers ([f5f81de](f5f81de)) * **secrets:** Can upload and download secrets to accounts an environments. ([0d17b77](0d17b77))
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our interpolation was using a forward lookahead for an unlimited amount of characters before, which could catch something like an
curl --fail localhost:3000/users || exit 1in the service config. The--would fail the regex match, and therefore not find the edges of a service for the graph. The regex has been updated to take this into account, and a test was added