Ephemeral component versions #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-cahill
changed the title
…emeral-component-versions
…emeral-component-versions
tjhiggins
requested changes
Aug 3, 2022
src/commands/deploy.ts
Outdated
| register.app = this.app; | ||
| await register.run(); | ||
| const component_spec = buildSpecFromPath(component); | ||
| component_names.push(`${account.name}/${component_spec.name}:${ComponentRegister.getTagFromFlags({ environment: environment.name })}`); |
There was a problem hiding this comment.
Remove the account name prefix. Since sometimes the account name is part of the name for older customers.
component_names.push(`${component_spec.name}:${ComponentRegister.getTagFromFlags({ environment: environment.name })}`);| @@ -56,6 +60,14 @@ export default class ComponentRegister extends BaseCommand { | |||
| description: 'Directory to write build cache to. Do not use in Github Actions: https://docs.architect.io/deployments/automated-previews/#caching-between-workflow-runs', | |||
| }), | |||
| }, | |||
| environment: { | |||
There was a problem hiding this comment.
should we make this hidden: true?
There was a problem hiding this comment.
I had considered that, but I don't see why someone shouldn't be able to create an ephemeral component version directly rather than indirectly thorough the deploy command
There was a problem hiding this comment.
What would be the reason for them to do that? My inclination is to make it hidden with the option to unhide in the future.
There was a problem hiding this comment.
Maybe they just don't want to deploy the component immediately after it's registered? I'll hide it though
src/commands/register.ts
Outdated
| @@ -20,6 +21,8 @@ import { IF_EXPRESSION_REGEX } from '../dependency-manager/spec/utils/interpolat | |||
|
|
|||
| tmp.setGracefulCleanup(); | |||
|
|
|||
| export const EPHEMERAL_DELIMITER = 'architect-ephemeral'; | |||
There was a problem hiding this comment.
Should we make it targeted to the environment? Not really a delimiter - more a prefix.
export const ENV_TAG_PREFIX = 'architect.environment.'
…emeral-component-versions
…emeral-component-versions
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
# [1.22.0-rc.7](v1.22.0-rc.6...v1.22.0-rc.7) (2022-08-04) ### Features * **deploy:** Ephemeral component versions ([#642](#642)) ([6d90449](6d90449))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
# [1.22.0](v1.21.1...v1.22.0) (2022-08-04) ### Bug Fixes * **dev:** Add ARC_DEV env for detecting if we are running locally ([85bc88c](85bc88c)) * **docs:** fix links to docs by making them absolute ([74ba274](74ba274)) * **exec:** Pass the proper auth header when using exec via token_type ([#646](#646)) ([54861dc](54861dc)) * **init:** debug block instead of interpolation ([#647](#647)) ([22e811c](22e811c)) * **sentry:** Sentry Refactor and Bug Fix ([#648](#648)) ([598034b](598034b)) ### Features * **deploy:** Ephemeral component versions ([#642](#642)) ([6d90449](6d90449)) * **spec:** support circular dependencies ([#641](#641)) ([86835ca](86835ca))
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TylerAldrich
pushed a commit
that referenced
this pull request
Aug 4, 2022
# [1.22.0](v1.21.1...v1.22.0) (2022-08-04) ### Bug Fixes * **dev:** Add ARC_DEV env for detecting if we are running locally ([85bc88c](85bc88c)) * **docs:** fix links to docs by making them absolute ([74ba274](74ba274)) * **exec:** Pass the proper auth header when using exec via token_type ([#646](#646)) ([54861dc](54861dc)) * **init:** debug block instead of interpolation ([#647](#647)) ([22e811c](22e811c)) * **sentry:** Sentry Refactor and Bug Fix ([#648](#648)) ([598034b](598034b)) ### Features * **deploy:** Ephemeral component versions ([#642](#642)) ([6d90449](6d90449)) * **spec:** support circular dependencies ([#641](#641)) ([86835ca](86835ca))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ephemeral components by allowing a user to register a component version with an environment