Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in stderr to logs #873

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Add in stderr to logs #873

merged 3 commits into from
Mar 31, 2023

Conversation

mueschm
Copy link
Member

@mueschm mueschm commented Mar 30, 2023

Overview

Make sure we pipe stderr to stderr

Changes

Make sure we pipe stderr to stderr

Tests

Showing errors it did not show before
image

Copy link
Contributor

@TylerAldrich TylerAldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, not sure if TJs comment is relevant though

@tjhiggins tjhiggins merged commit faf7729 into rc Mar 31, 2023
@tjhiggins tjhiggins deleted the stderr branch March 31, 2023 15:10
github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
## [1.36.2-rc.2](v1.36.2-rc.1...v1.36.2-rc.2) (2023-03-31)

### Bug Fixes

* **dev:** Add in stderr to logs ([#873](#873)) ([faf7729](faf7729))
github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
## [1.36.2](v1.36.1...v1.36.2) (2023-03-31)

### Bug Fixes

* **cluster:create:** Add checks for kubectl and server connection ([#870](#870)) ([03cecc2](03cecc2))
* **dev:** Add in stderr to logs ([#873](#873)) ([faf7729](faf7729))
@github-actions
Copy link

🎉 This PR is included in version 1.36.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants