Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #4

Merged
merged 9 commits into from
Sep 11, 2023
Merged

Tests #4

merged 9 commits into from
Sep 11, 2023

Conversation

ryanblock
Copy link
Contributor

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from master
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

Normalize request `host` properties
Fix missing body for !JSON requests
Fix possible response parsing error
Improve error metadata, especially connection errors
Enable error handler to immediately throw on raw errors
Enable error handler to handle wonky errors (like strings)
Improve error message construction
Validate main client `service` param
Fix `plugins` type check
@ryanblock ryanblock merged commit fcf4da4 into main Sep 11, 2023
19 checks passed
@ryanblock ryanblock deleted the tests branch September 11, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant