Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Workflows YAML Files uses incorrect parameter #69

Closed
Jonas-I opened this issue Oct 17, 2023 · 2 comments
Closed

GitHub Workflows YAML Files uses incorrect parameter #69

Jonas-I opened this issue Oct 17, 2023 · 2 comments

Comments

@Jonas-I
Copy link

Jonas-I commented Oct 17, 2023

The sample action files that use the Slack's Block Kit uses the slack-blocks parameter instead of slack-optional-blocks in .github/workflows/12-slack-message-blocks-update.yml and .github/workflows/11-slack-message-blocks.yml.
@archive
Copy link
Owner

archive commented Jan 30, 2024

Apologies for the confusion, but it appears that I inadvertently enabled both slack-blocks and slack-optional-blocks. Since these are now actively being used, removing one would result in a breaking change. To maintain stability, we will keep both options available for the time being...

@archive archive closed this as completed Jan 30, 2024
@archive
Copy link
Owner

archive commented Jan 30, 2024 •
edited
Loading

The following are now using the correct syntax, slack-optional-blocks :

  • 11-slack-message-blocks.yml
  • 12-slack-message-blocks-update.yml

To make sure we have backward compatibility, this test uses the old syntax, slack-optional-blocks:

  • 13-slack-message-blocks-backward-compatibility.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@archive @Jonas-I