Change config boolean examples

[davidhietpas]

Pretty minor but threw me for a loop. At least in version 2.1, I kept getting DB connection errors.

The config.rb example shows:
#AppConfig[:allow_unsupported_database] = false
#AppConfig[:allow_non_utf8_mysql_database] = false

The example output from the error log files suggest you change it to this:
AppConfig[:allow_unsupported_database] = "true"
AppConfig[:allow_non_utf8_mysql_database] = "true"

I thought it was odd that it switched from bool to string so I tried first the bool approach
AppConfig[:allow_unsupported_database] = true
AppConfig[:allow_non_utf8_mysql_database] = true

and the bool approach ended up not working. I did what the log suggested and switched it to a string and it worked.

I'd recommend making a change to the config.rb examples to use the correct syntax.

[lmcglohon]

Closed because moved to tech-docs repo: archivesspace/tech-docs#15

[lmcglohon]

After discussion with the technical documentation team, we decided to move this issue back to the main repo.

[lmcglohon]

I believe the issue is in the code for AppConfig[:allow_non_utf8_mysql_database]. The code is checking to see if the value is equal to a string here:

archivesspace/backend/app/model/db.rb

Line 53 in bc675bc

if !@opts[:skip_utf8_check] && pool.database_type == :mysql && AppConfig[:allow_non_utf8_mysql_database] != "true"

The example in the same file shows it as a string as well:

archivesspace/backend/app/model/db.rb

Line 389 in bc675bc

AppConfig[:allow_non_utf8_mysql_database] = "true"

.

I believe the appropriate fix is to change the two lines in backend/app/model/db.rb to use and set the value of AppConfig[:allow_non_utf8_mysql_database] as a boolean and leave the config_defaults.rb file as is. This will make is more consistent with the other true/false options in the cofiguration file.