btrfs-progs missing during mkinitcpio generation

[Torxed]

Strictly speaking this is an error that results in exit code 256 (1), but the image will still be generated.
But it causes archinstall to react on the exit code and aborts the installation.

Either we have to be more tolerant towards mkinitcpio and allow "bad" exit codes and check for Image generation successful, or we have to include btrfs-progs earlier in the steps.

[Torxed]

This logic is broken:

archinstall/archinstall/lib/installer.py

Lines 652 to 656 in 94d611d

	for partition in self.partitions:
	if partition.filesystem == 'btrfs':
	# if partition.encrypted:
	if 'btrfs-progs' not in self.base_packages:
	self.base_packages.append('btrfs-progs')

Because at the time of:

archinstall/archinstall/lib/installer.py

Line 716 in 94d611d

self.pacstrap(self.base_packages)

The following packages are installed: base base-devel linux-firmware linux

Which means this will "fail":

archinstall/archinstall/lib/installer.py

Line 748 in 94d611d

self.mkinitcpio('-P')

Verifiable with:

import archinstall
archinstall.get_partitions_in_use('/mnt/archinstall')
{}

[Torxed]

Trying to think of the best approach forward here.
Because technically those paths are on that partition, so that's not a lie.
But that partition doesn't have a mountpoint, because the subvolumes do.

[Torxed]

Easy tweak, I check if installation.target is inside the Partition.mountpoints instead of .mountpoint as we do recieve all the mountpoints from that function, including subvolumes.

[Torxed]

All in all, it was an error in detecting partitions in use. Because of pathlib.Path being introduced, and MapperDev missing a .mountpoints function.