Translation - UnicodeDecodeError 'utf-8' codec can't decode byte

[Torxed]

[Torxed]

A continue on the error skips the language entirely. But that's perhaps not ideal.

[svartkanin]

I think something went wrong here when merging in the translations files, let me have a look

[Torxed]

I thought that might be it. I also need to submit .mo files for all the languages as I haven't updated some of them yet.

[svartkanin]

Okay I got it fixed. But I'll also create a new github action to run a check on translation files as this has happened a few times now and it's difficult to detect especially when there's multiple translation PRs open

[Torxed]

Thank you! I'm also submitting a PR to state that we only wish contributors to submit .po files to ease with merging. And that we'll perform .mo creation later.

They should also only touch the specific language they're modifying, and not the base.pot file, as everyone will be updating that with every PR otherwise :)

What do we think about a global ignore on .mo? I can do a git add --force on them before release if that workflow works for everyone.

[svartkanin]

I don't think that's an easy one though unless it's possible with msgmerge and xgettext. Because running those will essentially update the base.pot and then populate the respective base.po files of each language. For people to see which texts have to be translated they will have to generate them.

We can ignore the .mo file, but not sure if that would help much?

[Torxed]

The .mo would help because quite often people update the same language, and .mo is not git friendly