Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premounted partitions systemd-boot issue #2138

Closed
JaKooLit opened this issue Oct 1, 2023 · 3 comments · Fixed by #2143
Closed

Premounted partitions systemd-boot issue #2138

JaKooLit opened this issue Oct 1, 2023 · 3 comments · Fixed by #2143

Comments

@JaKooLit
Copy link

JaKooLit commented Oct 1, 2023

so this is in connection to my previous issue
#2054

Anyway, the v2.6.3 have fix the grub issue. However the systemd-boot remains.

Screenshot_2023-10-02-00-59-47_18238

It seems that the UUID was not filled up.

Like I said above, I have tested grub and it was fixed. I have not tried other other bootloaders

here is the install log

install-systemd.log

It install just fine but it just does not boot since no UUID in the loader

@codefiles
Copy link
Contributor

I tested my last fix with GRUB and it worked so I submitted a pull request for it. After, I figured I had not done enough testing and tried with BTRFS subvolumes and systemd-boot and that did not work as I stated at the end here #2113 (comment). I then switched the pr to a draft and was going to come back to it. I saw the next day it had been marked as ready, approved, and merged. I thought maybe I did something wrong in my test and it worked.

I now see that the PartitionModification returned by PartitionModification.from_existing_partition() does not contain the partuuid. There also is a problem where the mount point for BTRFS subvolumes is not updated in DeviceHandler.detect_pre_mounted_mods() like it was for partitions with the last fix.

I will submit a fix shortly. Please test and report back. Thanks.

@JaKooLit
Copy link
Author

JaKooLit commented Oct 2, 2023

yeah sure I'll be happy to test it.

@JaKooLit
Copy link
Author

JaKooLit commented Oct 2, 2023

Perfect. tested the current master with systemd-boot and ext4. and its working. Thanks for the efforts.

Will try as well btrfs, grub systemd and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants