Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Linux keyring can't be assumed installed #44

Closed
Foxboron opened this issue Nov 21, 2018 · 4 comments
Closed

Arch Linux keyring can't be assumed installed #44

Foxboron opened this issue Nov 21, 2018 · 4 comments

Comments

@Foxboron
Copy link
Member

@coderobe

We should fetch the keyring, or have a list of keys we need somewhere so we can recv them.

@coderobe
Copy link
Member

Should be easy, https://github.com/Foxboron/archlinux-repro/blob/3976ebc2da1475677495767d13a98b7a677ff422/buildinfo#L106 is the only usage i think?

Is the keyring alone available directly anywhere?

@kpcyrd
Copy link
Member

kpcyrd commented Nov 21, 2018

@coderobe invoking gpg like that is exploitable, it may return success without actually verifying ${filename}. iirc the filename needs to be specified in argv explicitly to force verification of a detached signature.

@coderobe
Copy link
Member

yeah, you're right - though we're only downloading from our archive anyways. https://github.com/Foxboron/archlinux-repro/blob/3976ebc2da1475677495767d13a98b7a677ff422/buildinfo#L70 patches welcome!

@Foxboron
Copy link
Member Author

Fixed with 1dc31a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants