Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro only uses one core to build #67

Closed
kpcyrd opened this issue Apr 21, 2020 · 10 comments · Fixed by #72
Closed

repro only uses one core to build #67

kpcyrd opened this issue Apr 21, 2020 · 10 comments · Fixed by #72

Comments

@kpcyrd
Copy link
Member

kpcyrd commented Apr 21, 2020

I'm not sure if this is intentional, due to makepkg or due to nspawn. Having all cores available would be great when rebuilding core since it contains multiple gcc packages. :)

@Foxboron
Copy link
Member

Two folded. /usr/share/devtools doesn't set it. If anything it is read from ~/.makepkg.conf and do you want us to just set MAKEPKG="-j$(nproc)" by default in the container?

@FFY00
Copy link
Member

FFY00 commented Apr 21, 2020

I think repro should do the same as devtools and keep {SRC,SRCPKG,PKG,LOG}DEST, MAKEFLAGS and PACKAGER from the host makepkg.conf.

@Foxboron
Copy link
Member

@FFY00 There is no host makepkg.conf. Repro does not assume an Arch LInux host, which is why it goes through the current troubles.

@FFY00
Copy link
Member

FFY00 commented Apr 21, 2020

Check in /etc/makepkg.conf and then ~/.makepkg.conf. Is there anyone conflicting with us on /etc/makepkg.conf?

@Foxboron
Copy link
Member

Well yes. Pacman is packaged in several distros. I'd rather supply nproc or allow MAKEFLAGS env variables then providing a makepkg.conf file

@FFY00
Copy link
Member

FFY00 commented Apr 21, 2020

Yes, and why is it not acceptable to read /etc/makepkg.conf if we document it?

And sorry, I messed up the order. I meant check ~/.makepkg.conf first and then fallback to /etc/makepkg.conf.

@kpcyrd
Copy link
Member Author

kpcyrd commented Apr 21, 2020

The issue of defaulting to one core is that it's going to become a common gotcha because this becomes an extra step in the setup instructions of a rebuilder. People running rebuilders shouldn't be required to have the same level of experience as packagers.

@FFY00
Copy link
Member

FFY00 commented Apr 21, 2020

If packagers can't deal with this then we are all doomed.

I am not thinking of any major reason why we couldn't read /etc/makepkg.conf in other distributions, at least for getting MAKEFLAGS. If this is really a problem then we can add a build system flag to disable this behavior.

But anyway, it isn't a big deal.

@Foxboron
Copy link
Member

Repro isn't suppose to be used by packagers. But by users that want to reproduce their packages.

@FFY00
Copy link
Member

FFY00 commented Apr 21, 2020

Right, very well.

I still think a build system flag to enable/disable this behavior is a good solution.

But maybe we should just default to -j$(nproc) as a user should not be expected to edit a makepkg.conf to get large builds to not take forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants