Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase problem in maps #5

Closed
RyanSiu1995 opened this issue Jan 15, 2019 · 5 comments
Closed

Rebase problem in maps #5

RyanSiu1995 opened this issue Jan 15, 2019 · 5 comments

Comments

@RyanSiu1995
Copy link
Contributor

Hi @archseer,
it seems the code in maps is being rebased.
Some of the implementation is cleared. Can you please help fix the problem?
Thank you!
@archseer
Copy link
Owner

What commits are missing? I'll take a look in a few hours

@archseer
Copy link
Owner

Ah I see it now, my rebase was bad, will fix! Feel free to just drop my last commit on your branch

@archseer
Copy link
Owner

I'll stop committing to master and open PRs myself now as well

@RyanSiu1995
Copy link
Contributor Author

I just rebase from the master after you have fixed it. I wait for you :)

@archseer
Copy link
Owner

Fixed with f834d48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@archseer @RyanSiu1995