Flags not implemented

[aparks5]

By the way, fantastic extension, puzzled why there aren't more users.

Repro: attempt to record screen in full quality (no encoding, would like text to remain crisp)

 "chronicler.recording-defaults": {
        "fps": 30,
        "countdown": 1,
        "flags": "-video_size 1920x1080 -framerate 30 -f x11grab -i :0.0 -c:v libx264 -crf 0 -preset ultrafast"
    }

Result: flags not applied, image still blurry

[arciisine]

Thanks for the feedback. I'll take a look at why that is the case, as those should supersede the default values. Additionally, it seems like it would be a good idea to provide the ability to adjust quality/size accordingly.

[arciisine]

Okay, looking a little closer, most things are overridable (save for the desktop/layout pieces). Flags is expecting an object, instead of a string, e.g.:

"chronicler.recording-defaults": {
        "fps": 30,
        "countdown": 1,
        "flags": {
            "crf": 0,
        }
    }

Not all flags are currently overridable, there is a bug fix for arciisine/screen-recorder#1 that I will be releasing.

Additionally, to support quicktime, we use the yuv420 color space which causes some of the colors to look washed out, and seem less crisp. With the next release, this should be configurable.

Also, please take a look at https://github.com/arciisine/screen-recorder if you are looking for a simpler interface for screen recording, this is what the vscode plugin is built upon.

[arciisine]

I released with a better color profile, let me know if this looks better.

[arciisine]

Closing assuming the latest release solved the issue.