Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global template support #16

Closed
arctic-hen7 opened this issue Jul 8, 2021 · 5 comments · Fixed by #21
Closed

Global template support #16

arctic-hen7 opened this issue Jul 8, 2021 · 5 comments · Fixed by #21
Labels
enhancement New feature or request

Comments

@arctic-hen7
Copy link
Owner

Description
Support for a global template in ~/.bonnie/template.toml that would automatically be used instead of the pre-programmed default if it's present when bonnie -i is executed.

Reasoning
Bonnie currently lacks any form of global configuration ability. This is the best solution that provides both global configuration and atomicity and portability.

Are you willing to work on an implementation of this?
I'm happy to, but I think @ostev wanted to.

@arctic-hen7 arctic-hen7 added enhancement New feature or request triage This issue needs to be examined by a maintainer labels Jul 8, 2021
@arctic-hen7
Copy link
Owner Author

For reference, this was originally proposed in #12.

@ostev
Copy link
Contributor

ostev commented Jul 8, 2021

I'm currently working on a PR. I'm no Rustacean, so it will take me a little while.

One question: do you prefer ~/bonnie.toml or ~/.bonnie/template.toml?

@ostev
Copy link
Contributor

ostev commented Jul 8, 2021

Also: perhaps a merging of global with local configs would be interesting at runtime? That way you could use your own shell on open-source projects that do not use your shell.

@arctic-hen7
Copy link
Owner Author

Great! No problem, let me know on Gitter if I there's anything you need. I think ~/.bonnie/template.toml would make more sense.

@arctic-hen7
Copy link
Owner Author

Also: perhaps a merging of global with local configs would be interesting at runtime? That way you could use your own shell on open-source projects that do not use your shell.

I'm not so much in favor of this at the moment. Bonnie needs to be portable, and everyone should get the same, predictable results at runtime. Each configuration file should be entirely self-contained.

@arctic-hen7 arctic-hen7 removed the triage This issue needs to be examined by a maintainer label Jul 8, 2021
This was referenced Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants