Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code improvements #110

Merged
merged 6 commits into from
Jan 16, 2022
Merged

Minor code improvements #110

merged 6 commits into from
Jan 16, 2022

Conversation

Asha20
Copy link
Contributor

@Asha20 Asha20 commented Jan 12, 2022

No description provided.

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thank you very much!

I'll say that the changes to ErrorPages don't constitute a breaking change because from looking at them I don't think they should break any user-facing code (and custom engines aren't supported yet), is that correct?

@arctic-hen7
Copy link
Member

This seems to have some conflicts, are you able to resolve those?

@Asha20
Copy link
Contributor Author

Asha20 commented Jan 13, 2022

Alright, merge conflicts resolved.

Actually, I think this might be a breaking change because of the parameter type change from status: &u16 to status: u16; see this commit. Looking through the commit diff I see that I also had to update the parameters of files inside examples.

@arctic-hen7
Copy link
Member

I genuinely have no clue why that comment was in italics, sometimes the GitHub mobile app is magical.

I don't see any changes to the parameters that examples take, I think they've always taken owned values haven't they?

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this isn't a breaking change, it's good to merge.

@arctic-hen7
Copy link
Member

Yeah @Asha20 I'm pretty sure you've just needed to change some things in .perseus/ (which we work on inside examples/basic/, I know...), which doesn't constitute a breaking change.

@arctic-hen7 arctic-hen7 merged commit 2c0d344 into framesurge:main Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants