Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tribble fails to create github issue if issue description is too long, losing data #4

Closed
marienz opened this issue Feb 27, 2023 · 4 comments

Comments

@marienz
Copy link

marienz commented Feb 27, 2023

Trying to file an issue against Perseus that included a somewhat lengthy compiler error, clicking "create issue" resulted in a "Whoa there! Your request URL is too long. " error from Github.

This wouldn't be too bad if the browser back button worked, but it does not. The back button took me back to the "Welcome to the contributing website for Perseus!" page.

(Sorry for the wonky issue editing, I hit the wrong keyboard shortcut 😅 )

@marienz marienz changed the title Tribble Tribble fails to create github issue if issue description is too long, losing data Feb 27, 2023
@arctic-hen7
Copy link
Owner

Ah, that's a problem! You should be able to just copy it into GH, but Tribble should stop you from submitting through the URL system if the issue is too long. This should be fairly easy to fix, provided we know how long is too long...

@marienz
Copy link
Author

marienz commented Feb 28, 2023

Ugh, I assumed the limit would be documented and/or POST would have a higher limit, but glancing at https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-an-issue#creating-an-issue-from-a-url-query it does not mention either of those things... If the limit isn't documented, relying on the current value seems unwise.

Maybe make the "create issue" link open in a new tab? That'd at least circumvent any back button issues.

@arctic-hen7
Copy link
Owner

Oh yay. Good idea, let's go with that, and I'll experiment to figure out what their length limit is in practice for a warning.

@arctic-hen7
Copy link
Owner

Note that this can't actually be released until I update Tribble to use Perseus v0.4, due to underlying issues in the v0.3.6 CLI related to an upstream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants