Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Hashid.EMPTY instead of Exception when passing negative long numbers? #4

Closed
arcticicestudio opened this issue Oct 16, 2016 · 0 comments
Closed

Return Hashid.EMPTY instead of Exception when passing negative long numbers? #4

arcticicestudio opened this issue Oct 16, 2016 · 0 comments
Labels
resolution-superseded type-improvement type-proposal

Comments

@arcticicestudio
Copy link
Owner

arcticicestudio commented Oct 16, 2016 •
edited
Loading

Superseded by #9

If the list of long numbers passed to the + doEncode(long...) : Hashid method contains a negative value a java.lang.IllegalArgumentException ("Number out of range") exception will be thrown.
The original implementation behaviour is to return an empty string.
Should the library also return an empty list (Hashid.EMPTY) or leave the behaviour as it is for a better exception management?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution-superseded type-improvement type-proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arcticicestudio