Fix syntax error introduced in GH-81 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syntax error keeps Nord from loading, please fix.
Fix syntax error
arcticicestudio
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Hi @rien333 👋, thanks for your contribution 👍
Really good catch thanks 💪
I've also overlooked the extra brace in #81, wasn't really easy to see next to changed number.
I'm not a Emacs user, but I guess it makes sense to connect the develop branch to MELPA since Nord is available in both, the stable repository/registry as well as the bleeding edge one.
svengreb
approved these changes
Dec 3, 2019
arcticicestudio
referenced
this pull request
Dec 3, 2019
It now uses the whole "Frost" palette. It used `nord8` for all levels before to match the style of Markdown syntax in Emacs as well as other projects, but it makes sense for this package to use different colors since users might expect it. This also matches the default style of the Org-Mode package that makes use of different colors. Additionaly this comit removed a duplicate line.
arcticicestudio
pushed a commit
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme fails to load due to this syntax error, please fix. (also, why is the melpa package connected to the development branch? because of things like this, it makes more sense to connect it to the master branch)