Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Remove italic from braces in RegExp #107

Closed
n1kk opened this issue Nov 12, 2019 · 1 comment · Fixed by #111
Closed

[Suggestion] Remove italic from braces in RegExp #107

n1kk opened this issue Nov 12, 2019 · 1 comment · Fixed by #111
Labels
context-syntax scope-quality scope-ux status-accepted type-improvement
Milestone
0.9.0

Comments

@n1kk
Copy link

n1kk commented Nov 12, 2019

Is there a reason why RegExp braces []{} are italic?

I think regular style makes it more readable.
image
image
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 12, 2019 •
edited

Hi @n1kk 👋, thanks for your contribution 👍
That's not the way it should be, I guess something went wrong during the transition from the old to the new theme API. It looks way cleaner and less distracting without italic font style especially because it is mixed with normal styles.
This can be included in the next release version, feel free to submit a PR if you like 😄

@arcticicestudio arcticicestudio added this to the Next milestone Nov 12, 2019
svengreb pushed a commit that referenced this issue Dec 16, 2019
@arcticicestudio
Remove italic font style for RegEx braces and brackets
13b2821 
During the transition from the old to the new theme API the font style
for RegEx braces and brackets were changed to "italic".

GH-107
@arcticicestudio arcticicestudio self-assigned this Dec 16, 2019
@arcticicestudio arcticicestudio mentioned this issue Dec 16, 2019
Merged
arcticicestudio added a commit that referenced this issue Dec 16, 2019
@arcticicestudio
Remove italic font style for RegEx braces and brackets (#111)
2e3d411 
During the transition from the old to the new theme API the font style
for RegEx braces and brackets were changed to "italic".
It looks way cleaner and less distracting without italic font style especially because it is mixed with normal styles.

Resolves GH-107
@arcticicestudio arcticicestudio removed their assignment Dec 16, 2019
svengreb pushed a commit that referenced this issue Dec 16, 2019
@arcticicestudio
Remove italic font style for RegEx braces and brackets (#111)
2e099a7 
During the transition from the old to the new theme API the font style
for RegEx braces and brackets were changed to "italic".
It looks way cleaner and less distracting without italic font style especially because it is mixed with normal styles.

Resolves GH-107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax scope-quality scope-ux status-accepted type-improvement
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Remove italic font style for RegEx braces and brackets nordtheme/jetbrains
2 participants
@n1kk @arcticicestudio