Support 2019.2 deprecation replacement UI theme keys #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svengreb
previously approved these changes
Aug 1, 2019
The latest JetBrains product versions 2019.2 deprecated some UI them keys in favour of new keys. This broke the styles when using the Nord plugin with the latest product versions due to the missing new keys. In order to support both versions `<2019.2` as well as `>=2019.2` the new keys have been added while also keeping the deprecated ones until they'll be removed from the UI theme API. 1. Editor tabs using new keys for the active background (`underlinedTabBackground`) and when hovered (`hoverMaskColor`) and also now support customization of the bottom stripe when not focused (`inactiveUnderlineColor`). 2. Debugger tabs are now using a new key for the background color (`underlinedTabBackground`) when active. 3. The auto-completion popup now uses the same color like the `DOCUMENTATION_COLOR` attribute of the editor color scheme as well as a new key for the currently active selection (`selectionBackground`). 4. The components of the status bar now using a new key to for the background color when hovered (`hoverBackground`). GH-86
arcticicestudio
force-pushed
the
feature/gh-86-deprecation-replacement-ui-theme-keys-2019.2
branch
from
96b3cfa
to
2cfd022
Compare
svengreb
approved these changes
Aug 1, 2019
arcticicestudio
deleted the
feature/gh-86-deprecation-replacement-ui-theme-keys-2019.2
branch
arcticicestudio
added a commit
that referenced
this pull request
Aug 3, 2019
In version 0.8.0 (1) some new UI theme keys have been added and deprecated ones modified or removed through GH-86 and PR GH-87. This included the `ui.CompletionPopup.nonFocusedMask` key that has been set to `nord0` without a alpha layer value. Since the auto completion popup of IntelliSense if not focused but the editor itself, the overlay mask gets applied. As soon as the up or down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles. The key has been removed, the popup should be shown the same like in focused state for better readable text and easy recognition of the desired auto complete entry. References: (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0 GH-88
arcticicestudio
added a commit
that referenced
this pull request
Aug 3, 2019
In version 0.8.0 (1) some new UI theme keys have been added and deprecated ones modified or removed through GH-86 and PR GH-87. This included the `ui.CompletionPopup.nonFocusedMask` key that has been set to `nord0` without a alpha layer value. Since the auto completion popup of IntelliSense if not focused but the editor itself, the overlay mask gets applied. As soon as the up or down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles. The key has been removed, the popup should be shown the same like in focused state for better readable text and easy recognition of the desired auto complete entry. References: (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0 Fixes GH-88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews
Editor Tabs
Before
After
Auto Completion Popup
Before
After
Debugger Tabs
Before
After
Status Bar Components
Before
After
Hovering Editor Tabs & Status Bar Components
Before
Hovering Editor Tabs & Status Bar Components