Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for php.vim plugin #262

Closed
arcticicestudio opened this issue Jun 9, 2021 · 0 comments · Fixed by #263
Closed

Support for php.vim plugin #262

arcticicestudio opened this issue Jun 9, 2021 · 0 comments · Fixed by #263
Labels
context-plugin context-syntax scope-compatibility scope-quality type-feature
Milestone
version-0.16.0

Comments

@arcticicestudio
Copy link
Contributor

This is a follow up for arcticicestudio/nord-vim#218 which added highlighting groups for the bundled PHP syntax, but the groups are actually defined by the StanAngeloff/php.vim plugin. Therefore the added highlighting calls will be moved to a plugin section.
Additionally, the phpClassExtends and phpClassImplements groups will be added to improve the highlighting for classes that implement or extended interfaces/classes. The phpUseClass will also be added to improve the highlighting for imports.
@arcticicestudio arcticicestudio added this to the 0.16.0 milestone Jun 9, 2021
@arcticicestudio arcticicestudio mentioned this issue Jun 9, 2021
Merged
arcticicestudio added a commit that referenced this issue Jun 9, 2021
@arcticicestudio @svengreb
Support for php.vim plugin (#263)
07452c7 
This is a follow up for #218 [1] which added
highlighting groups for the bundled PHP syntax, but the groups are
actually defined by the StanAngeloff/php.vim [2] plugin.
Therefore the added highlighting calls will be moved to a plugin
section.
Additionally, the `phpClassExtends` and `phpClassImplements` groups
have been added to improve the highlighting for classes that implement
or extended interfaces/classes. The `phpUseClass` has also been added to
improve the highlighting for imports.

[1]: #218
[2]: https://github.com/StanAngeloff/php.vim

Related to GH-218
Closes GH-262

Co-authored-by: Sven Greb <development@svengreb.de>
crispgm pushed a commit to crispgm/nord-vim that referenced this issue Jun 10, 2021
@arcticicestudio @svengreb @crispgm
Support for php.vim plugin (nordtheme#263)
415ef07 
This is a follow up for nordtheme#218 [1] which added
highlighting groups for the bundled PHP syntax, but the groups are
actually defined by the StanAngeloff/php.vim [2] plugin.
Therefore the added highlighting calls will be moved to a plugin
section.
Additionally, the `phpClassExtends` and `phpClassImplements` groups
have been added to improve the highlighting for classes that implement
or extended interfaces/classes. The `phpUseClass` has also been added to
improve the highlighting for imports.

[1]: nordtheme#218
[2]: https://github.com/StanAngeloff/php.vim

Related to nordthemeGH-218
Closes nordthemeGH-262

Co-authored-by: Sven Greb <development@svengreb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-plugin context-syntax scope-compatibility scope-quality type-feature
Projects
None yet
Milestone
version-0.16.0
Development

Successfully merging a pull request may close this issue.

Support for php.vim plugin nordtheme/vim
2 participants
@arcticicestudio @svengreb