Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hightlight whole line on hightlighted Neovim health check text makes it disappear #31

Closed
syedelec opened this issue May 10, 2017 · 6 comments · Fixed by #42
Closed

hightlight whole line on hightlighted Neovim health check text makes it disappear #31

syedelec opened this issue May 10, 2017 · 6 comments · Fixed by #42

Comments

@syedelec
Copy link

Hi,

I am using neovim with colorscheme nord (installed separately in colors/ folder), I removed all plugins and personal configuration. cursorline is set to highlight the whole line.

Here is the result for :CheckHealth

screenshot-20170510130722-941x329

Thanks.

@arcticicestudio
Copy link
Contributor

Thanks for your report 👍
Sorry for my late reply, I've been busy with my job.

Is this reproducible in Vim terminal- or GUI mode? The theme has not been optimized for NVim so there might be differences/problems.

@dylnmc
Copy link
Contributor

dylnmc commented Jul 16, 2017

It seems that the hl group is healthWarning in neovim, and miraculously, the fg is set to black and the bg is set to color of :hi CursorLine? The other groups are healthError and healthSuccess.

Doing :set nocursorline corrects the issue, but it does not solve the problem. Hope this helps.


healthSuccess:

screenshot from 2017-07-16 19-55-04


with cursorline:

screenshot from 2017-07-16 19-55-56

@dylnmc
Copy link
Contributor

dylnmc commented Jul 17, 2017

It's not just this colorscheme that is having issues, though:

screenshot from 2017-07-16 20-08-57

Also, doing :highlight healthStatus ctermfg=0 ctermbg=2 still had same problem (except worse):

screenshot from 2017-07-16 20-11-37

I am going to check freenode / neovim to see if anyone knows about this and I will probably post an issue on neovim's gh.

@dylnmc
Copy link
Contributor

dylnmc commented Jul 17, 2017

After poking around on freenode for a bit, it may have something to do with neovim/neovim#6380

I haven't really looked into it.


regards to sunjon on #vim on freenode

@dylnmc
Copy link
Contributor

dylnmc commented Jul 17, 2017

:highlight healthSuccess ctermfg=2 ctermbg=0
:highlight healthWarning ctermfg=3 ctermbg=0
:highlight healthSuccess ctermfg=1 ctermbg=0

seem to be ok, though.. (if this fits the style guidelines)

screenshot from 2017-07-16 21-59-17


Hopefully, this issue is resolved with neovim, though

@arcticicestudio arcticicestudio changed the title hightlight whole line on hightlighted text makes it disappear hightlight whole line on hightlighted Neovim health check text makes it disappear Jul 17, 2017
@arcticicestudio
Copy link
Contributor

Thanks again @dylnmc for your detailed investigation, it really helps a lot to get me tings done faster 👍
I've created a PR for it.

@arcticicestudio arcticicestudio added this to the 0.6.0 milestone Jul 17, 2017
arcticicestudio added a commit that referenced this issue Aug 3, 2017
…health-check-background-highlight-current-line

Neovim health check highlight status groups support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants