Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search highlight on strings illegible #32

Closed
syedelec opened this issue May 10, 2017 · 4 comments · Fixed by #39
Closed

search highlight on strings illegible #32

syedelec opened this issue May 10, 2017 · 4 comments · Fixed by #39

Comments

@syedelec
Copy link

Hi,

The same configuration as previous issue without cursorline set:
I am using neovim with colorscheme nord (installed separately in colors/ folder), I removed all plugins and personal configuration.

During the search for a text between quotes, the highlighting color is incorrect (right)
Once I validate my search, the behavior is correct (left)
incsearch is activated by default

screenshot-20170510134214-954x524

Thanks.

@arcticicestudio
Copy link
Contributor

Thanks for your report 👍
Sorry for the late reply, I've been busy with my job.

I've pushed a fix for it.

Before

After

@syedelec @dylnmc You can check out 🌱 bugfix/gh-32-search-highlight-on-strings-illegible to test the changes.

@dylnmc
Copy link
Contributor

dylnmc commented Jul 15, 2017

Folds still are not visible for me. Is that how they are supposed to look?

screenshot from 2017-07-15 17-20-09

(and I am going to assume comments are supposed to be that low contrast.)

Thanks for fixing the highlight on strings.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jul 16, 2017

@dylnmc I've posted some information about the low contrast comment design in #36 .
The fold marker are indeed not optimal, I'll adjust them to match the comment color (#38).

@syedelec
Copy link
Author

The fix works on my neovim configuration, Thank you !

arcticicestudio added a commit that referenced this issue Aug 3, 2017
…ight-on-strings-illegible

Fix unreadable text color on pending search result highlights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants