Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for plasticboy/vim-markdown #45

Closed
hexacera opened this issue Jul 26, 2017 · 6 comments · Fixed by #57
Closed

Support for plasticboy/vim-markdown #45

hexacera opened this issue Jul 26, 2017 · 6 comments · Fixed by #57

Comments

@hexacera
Copy link

The highlighting for Markdown will stop to work once 'plasticboy/vim-markdown' is installed. Could it be because they have a different system of syntax naming? I never had any Markdown highlighting problem with other color schemes before.

Expected:
screen shot 2017-07-27 at 1 04 25 am

Actual:
screen shot 2017-07-27 at 1 03 02 am

@arcticicestudio
Copy link
Contributor

Thanks for your report 👍
I'll try to reproduce this within the next days, but my guess is that they are using a custom variable namespace which needs to be implemented as plugin support into this theme.

@powelleric
Copy link

Just confirming that I also am experiencing this behavior. Switching to a different colorscheme resolves the issue....whatever that is.

@powelleric
Copy link

I think you are correct about the "custom variable namespace". I looked through the repository OP linked to and in the syntax/markdown.vim file I saw this type of stuff.

"HTML headings
syn region htmlH1       start="^\s*#"                   end="$" contains=mkdLink,mkdInlineURL,@Spell
syn region htmlH2       start="^\s*##"                  end="$" contains=mkdLink,mkdInlineURL,@Spell
syn region htmlH3       start="^\s*###"                 end="$" contains=mkdLink,mkdInlineURL,@Spell
syn region htmlH4       start="^\s*####"                end="$" contains=mkdLink,mkdInlineURL,@Spell
syn region htmlH5       start="^\s*#####"               end="$" contains=mkdLink,mkdInlineURL,@Spell
syn region htmlH6       start="^\s*######"              end="$" contains=mkdLink,mkdInlineURL,@Spell

Anyway, not sure if that is a lot of work to implement but it would be really appreciated.

@powelleric
Copy link

I was able to get some basic highlighting working with the custom variable namespace. I added these lines at line 304 of colors/nord.vim and it seems to work.

It would be great to get more of this namespace mapped to nord because this seems to be a quite popular vim plugin (+2000 stars).

Here is a link to the syntax file showing other regions that need to be mapped, https://github.com/plasticboy/vim-markdown/blob/master/syntax/markdown.vim


hi! link htmlH1 markdownH1
hi! link htmlH2 markdownH1
hi! link htmlH3 markdownH1
hi! link htmlH4 markdownH1
hi! link htmlH5 markdownH1
hi! link htmlH6 markdownH1
hi! link mkdListItem markdownListMarker
hi! link mkdListItemLine markdownListMarker
hi! link mkdBold Bold
hi! link mkdItalic Italic

@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Sep 22, 2017
arcticicestudio added a commit that referenced this issue Sep 23, 2017
This adds support for the language plugin plasticboy/vim-markdown to
match the style of the built-in markdown syntax styles.

GH-45
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Sep 23, 2017

@VVVFO @powelleric Sorry for the delay, unfortunately had not much free time to work on my projects. I've opened PR #57 which implements support for the plugin. It would be nice if you can test the changes and see if it works and you'd expect it to be highlighted.

@hexacera
Copy link
Author

Justed tested, it worked perfectly! Thank you for your work @arcticicestudio !

arcticicestudio added a commit that referenced this issue Sep 25, 2017
…ort-plasticboy-vim-markdown

Language plugin support for plasticboy/vim-markdown
@arcticicestudio arcticicestudio removed their assignment Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants