Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely low contrast between cursorline and comment color #48

Closed
drzel opened this issue Aug 30, 2017 · 5 comments · Fixed by #56
Closed

Extremely low contrast between cursorline and comment color #48

drzel opened this issue Aug 30, 2017 · 5 comments · Fixed by #56

Comments

@drzel
Copy link
Contributor

drzel commented Aug 30, 2017

Really love this colorscheme, far and beyond any other. I use it wherever I can.

I realise it's subjective, but it's pretty hard to read comments as it is - and very tough under the cursorline.

@b0o
Copy link

b0o commented Sep 19, 2017

I agree. If there is any tiny amount of glare/excess light on my screen, comments are basically unreadable.

@arcticicestudio
Copy link
Contributor

The low contrast is by design of Nord and has been selected specifically to not disturb code flow and keep the focus of the developer on the code.

It is totally fine that you not agree to all highlighting color assignments, everyone has different preferences. That is the reason why themes exist 😄
You can customize the theme via your ~/.vimrc by pasting the following snippet somewhere before you set the color scheme (colorscheme nord) and than add your custom syntax highlighting rules you want to override:

augroup nord-overrides
  autocmd!
  autocmd ColorScheme nord highlight Comment ctermfg=<COLOR> guifg=<COLOR>
augroup END

The overriden rules will only be applied for Nord and won't affect other themes.

This is a reference table if you'd like to use the same increased contrast values as provided by the Nord Atom Syntax accessibility custom comment contrast theme setting feature which are calculated using the LESSCSS lighten function.

Increased by Calculated value
1% #4e586d
2% #505b70
3% #525d73
4% #556076
5% #576279
6% #59647c
7% #5b677f
8% #5d6982
9% #5f6c85
10% #616e88
11% #63718b
12% #66738e
13% #687591
14% #6a7894
15% #6d7a96
16% #6f7d98
17% #72809a
18% #75829c
19% #78859e
20% #7b88a1

@drzel
Copy link
Contributor Author

drzel commented Sep 20, 2017

Thanks so much for taking the time to explain this. I've been looking into how to do exactly what you describe.

@b0o
Copy link

b0o commented Sep 23, 2017

Thank you! I find that bumping the comment color up just 5% to #576279 makes a world of difference.

arcticicestudio added a commit to drzel/nord-vim that referenced this issue Sep 23, 2017
Revert back the included code changes of the PRs
nordtheme#50 and nordtheme#53.

nordthemeGH-48
arcticicestudio added a commit to drzel/nord-vim that referenced this issue Sep 23, 2017
arcticicestudio added a commit to drzel/nord-vim that referenced this issue Sep 23, 2017
Fixed the indentation of the color array and replaced the single quote
characters.

nordthemeGH-48
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Sep 23, 2017

@b0o I've merged #56 so you can now change the percent with the new configuration. If you' re using vim-plug you can easily change the plugin to use the develop branch until version 0.7.0 is released.

Just add or adjust

Plug "arcticicestudio/nord-vim", { 'branch': "develop" }

in your ~/.vimrc and run :PlugInstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment