Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform diff background configuration #60

Closed
arcticicestudio opened this issue Sep 28, 2017 · 0 comments · Fixed by #61
Closed

Uniform diff background configuration #60

arcticicestudio opened this issue Sep 28, 2017 · 0 comments · Fixed by #61
Labels
context-config context-ui scope-ux type-feature
Milestone
version-0.7.0

Comments

@arcticicestudio
Copy link
Contributor

Supersedes #50

Add a theme configuration to let the users decide whether they want to use colorful or uniform diff backgrounds.

The colorful diff should be default using the current colors for added, changed and deleted elements and the default background color (nord0). The reverse attribute should be applied which will result in a colored background and a dark foreground.

gh-49-scrot-preview-colorful-after

Setting the g:nord_uniform_diff_background variable to 1 will enable the uniform diff background using nord1.

gh-49-scrot-preview-uniform
@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Sep 28, 2017
@arcticicestudio arcticicestudio self-assigned this Sep 28, 2017
arcticicestudio added a commit that referenced this issue Sep 28, 2017
@arcticicestudio
Implement uniform diff background theme config
7bdc220 
Added a theme configuration to let the users decide whether they want
to use colorful or uniform diff backgrounds.

The colorful diff is the default using the current colors for added,
changed and deleted elements and the default background color (nord0).
The "reverse" attribute gets applied which results in a colored
background and a dark foreground.

Setting the "g:nord_uniform_diff_background" variable to "1" enables
the uniform diff background using "nord1".

GH-60
@arcticicestudio arcticicestudio mentioned this issue Sep 28, 2017
Merged
@arcticicestudio arcticicestudio mentioned this issue Sep 28, 2017
Closed
arcticicestudio added a commit that referenced this issue Sep 28, 2017
@arcticicestudio
Merge pull request #61 from arcticicestudio/feature/gh-60-uniform-dif…
958322d 
…f-background-config

Uniform diff background theme configuration
@arcticicestudio arcticicestudio removed their assignment Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config context-ui scope-ux type-feature
Projects
None yet
Milestone
version-0.7.0
Development

Successfully merging a pull request may close this issue.

Uniform diff background theme configuration nordtheme/vim
2 participants
@arcticicestudio @svengreb