Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim tab completion highlight #64

Closed
markand opened this issue Oct 23, 2017 · 7 comments · Fixed by #80
Closed

vim tab completion highlight #64

markand opened this issue Oct 23, 2017 · 7 comments · Fixed by #80

Comments

@markand
Copy link

markand commented Oct 23, 2017

Hello,

Using your awesome vim color theme I have a small issue regarding the tab completion selector.

In fact, there is no different color when doing completion, see screenshot:

screen shot 2017-10-23 at 11 41 37 am

@dylnmc
Copy link
Contributor

dylnmc commented Oct 23, 2017

Hi, markand.

Do you, by any chance, do highlight StatusLine ctermbg=8 in your vimrc?

If not, can you show the output of :hi StatusLine?

By default, it should looke like this:

tmp

@markand
Copy link
Author

markand commented Oct 24, 2017

Hello,

No I don't have any hi command in my vimrc (see it).

But hi StatusLine shows ctermbg=8.

StatusLine     xxx term=bold,reverse ctermfg=6 ctermbg=8 guifg=#88C0D0 guibg=#4C566A

I use vim8 on Terminal.app (which I have imported your awesome color scheme too)

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 24, 2017

Is it reproducible with :set termguicolors?

And nice to see that you like the theme 😉

@markand
Copy link
Author

markand commented Oct 24, 2017

I don't know if the colors are correct but I don't get a different background:

screen shot 2017-10-24 at 9 26 15 am

@markand
Copy link
Author

markand commented Oct 24, 2017

Okay I'm sorry I've tested with the 0.6.0 version and everything works fine! It looks like the issue is only coming from master version.

@markand markand closed this as completed Oct 24, 2017
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 24, 2017

Alright, should be fixed via #58 which will be shipped with release version 0.7.0.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 9, 2017

@markand @dylnmc It turns out that this is a bug introduced with #58.
The implemented feature in this PR changed the background color of the status bar (StatusLine) group to nord3, but the WildMenu group also uses nord3 as background color for the current tab selection.

The solution is to change the WildMenu background color to nord1 which is available for both terminal (nord1_term) and GUI (nord1_gui) mode.

@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Nov 9, 2017
arcticicestudio added a commit that referenced this issue Dec 5, 2017
The implemented feature in this GH-58 changed the background color of
the status bar ("StatusLine") group to "nord3", but the "WildMenu" group
also useed "nord3" as background color for the current tab selection.

This commit changes the "WildMenu" background color to "nord1" which is
available for both terminal ("nord1_term") and GUI ("nord1_gui") mode.

Related to GH-58

GH-64
arcticicestudio added a commit that referenced this issue Dec 5, 2017
…on-highlight

Fix "WildMenu" background color for current selection (tab completion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants