Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Lsp codelens #266

Merged
merged 4 commits into from Sep 5, 2021
Merged

Conversation

jan-xyz
Copy link
Contributor

@jan-xyz jan-xyz commented Jul 10, 2021

code lenses are currently highlighted with the default color. This change adjusts it to make it less visually intrusive like comments. docs: https://neovim.io/doc/user/lsp.html#hl-LspCodeLens

Before:
125170561-cc6aa680-e1af-11eb-9a21-98bbdd62e821

After:
Screenshot 2021-07-10 at 19 28 57

It is based on the VS code highlighting:
Screenshot 2021-07-10 at 19 10 09

code lenses are currently highlighted with the default color. This change adjusts it to make it less visually intrusive like comments. It is based on the VS code highlighting.
@arcticicestudio
Copy link
Contributor

Hi @jan-xyz 👋, thanks for your contribution 👍
I'll try to test and review the changes this weekend.

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution. I've added a small improvement suggestion, otherwise this looks good to me 👍🏻

colors/nord.vim Outdated Show resolved Hide resolved
@jan-xyz
Copy link
Contributor Author

jan-xyz commented Jul 28, 2021

Done! :) Thanks for the feedback! Would you appreciate another PR that moves other Comments to the custom group as well?

@jan-xyz
Copy link
Contributor Author

jan-xyz commented Aug 8, 2021

hey @arcticicestudio, any news on getting this merged? 😊

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, I was on vacation for the last few weeks and I deliberately ignored the "digital life" during this time 😄

I reconsidered my previous suggestion and have come to the conclusion that the Comment the group is not right there due to the s:italicize_comments variable. Users who enabled this option would see code lenses being rendered with italic font style for an element that is more or less part of the UI and not the syntax. I guess for now we should use the dedicated definition from your initial PR commit and remove the s:italicize_comments variable. We can introduce a new custom highlighting group for elements like this later on. Sorry for this back and forth of changes 🙈

Would you appreciate another PR that moves other Comments to the custom group as well?

A PR that adds a new custom group for UI elements like code lenses or linter messages (like mentioned above) would be very welcome.

@jan-xyz
Copy link
Contributor Author

jan-xyz commented Sep 5, 2021

No need to apologize! I appreciate consistent behavior and as this is something new I totally understand that you haven't figured out and planned all of the quirks and bits yet! I'll see to it soon and I hope you had a great digital free vacation 🤗

@jan-xyz
Copy link
Contributor Author

jan-xyz commented Sep 5, 2021

@arcticicestudio I applied your requested changes

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will land in the next release with some other LSP and tree-sitter related improvements 🚀

@arcticicestudio arcticicestudio merged commit 02ddfad into nordtheme:develop Sep 5, 2021
arcticicestudio added a commit that referenced this pull request Sep 12, 2021
Support for LSP code lenses

Before LSP code lenses [1] where code lenses were highlighted with the
default color which has been changed to make it less visually intrusive,
like other UI related elements, i.e. messages of linters.

[1]: https://neovim.io/doc/user/lsp.html#lsp-highlight-codelens

GH-266


Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
@jan-xyz jan-xyz deleted the patch-1 branch December 1, 2021 13:46
@svengreb
Copy link
Member

Release Note Assets

Before

After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants