New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for neovim 0.6.0 diagnostic API highlight groups #282
Conversation
The highlight groups changed in nevoid 0.6.0 See: https://github.com/neovim/neovim/blob/99f6260f84a8ef94495c831155d98c330078e0ad/runtime/doc/diagnostic.txt#L187
Nord maintainer is not responding on the following pr: nordtheme/vim#282. Currently diagnostics colors are broken in nord theme as the highlight groups changed in nevoid 0.6.0
Hi @jan-xyz 👋, thanks for your contribution 👍 Anyway, I guess we should keep the previous groups and guard it with a Neovim version check to continue to support |
Sounds reasonable! I will get to it as soon as possible |
Please do not rush over the Christmas holidays, spending time with the family and loved ones is more important than some lines of code. |
I applied that change, and guard now the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, happy new year 🎉🍀
The guard looks good to me, thanks again 👍🏻
Same to you! 💟 |
…me#282) In Neovim `0.6.0` [1] the naming scheme for the highlight groups of the diagnostic API changed [2]. The new groups have been added as default while the previous groups are conditionally guarded when using Neovim `0.5.0`. [1]: https://github.com/neovim/neovim/releases/tag/v0.6.0 [2]: neovim/neovim@a5bbb93#diff-51fab2b766d0a3b606462e95de492190df173b7296147912307cdad636cd492aR77 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> nordthemeGH-282
In Neovim `0.6.0` [1] the naming scheme for the highlight groups of the diagnostic API changed [2]. The new groups have been added as default while the previous groups are conditionally guarded when using Neovim `0.5.0`. [1]: https://github.com/neovim/neovim/releases/tag/v0.6.0 [2]: neovim/neovim@a5bbb93#diff-51fab2b766d0a3b606462e95de492190df173b7296147912307cdad636cd492aR77 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> GH-282
The highlight groups introduced in Neovim 0.5.0 specifically for LSP have been changed in neovim 0.6.0 to a general purpose Diagnostics API.
See: https://github.com/neovim/neovim/blob/99f6260f84a8ef94495c831155d98c330078e0ad/runtime/doc/diagnostic.txt#L187
This makes sure that Nord works with the new version of neovim. However, it keeps compatibility with the previous highlight groups used in 0.5.0.
Try it out in packer:
Thanks for taking your time and working on this <3
Jan