Improve readability of C language constants #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcticicestudio
requested changes
Jan 25, 2022
There was a problem hiding this comment.
Hi @jvoisin 👋, thanks for your contribution 👍
Good improvement, but I'd like to suggest to use the Type highlighting group instead of Exception just to make it more clear that these are more or less language native types. Looks like there are a lot of matched constants for the C Vim syntax so this should definitely a good visual improvement.
Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
svengreb
approved these changes
Jan 25, 2022
arcticicestudio
approved these changes
Jan 25, 2022
arcticicestudio
changed the title
Release note & changelog assetsBefore
After
|
jcypret
pushed a commit
to jcypret/nord-vim-midnight
that referenced
this pull request
Feb 19, 2022
Improve readability of C language constants To improve the readability of C language constants, defined by the `cConstant` syntax highlighting group [1], these are now colored with `nord9` for the foreground to make them stand out. This is important in C, since interesting things are usually happening in their proximity, like checking/returning an error, passing particular values/flags to functions and so on. [1]: https://github.com/vim/vim/blob/0e6adf8a29d5c2c96c42cc7157f71bf22c2ad471/runtime/syntax/c.vim#L313-L375 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> nordthemeGH-283
crispgm
added a commit
to crispgm/nord-vim
that referenced
this pull request
Apr 2, 2022
arcticicestudio
pushed a commit
that referenced
this pull request
May 14, 2022
Improve readability of C language constants To improve the readability of C language constants, defined by the `cConstant` syntax highlighting group [1], these are now colored with `nord9` for the foreground to make them stand out. This is important in C, since interesting things are usually happening in their proximity, like checking/returning an error, passing particular values/flags to functions and so on. [1]: https://github.com/vim/vim/blob/0e6adf8a29d5c2c96c42cc7157f71bf22c2ad471/runtime/syntax/c.vim#L313-L375 Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de> GH-283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits makes constant stand out. This is important in C, since interesting things are usually happening in their proximity, like checking/returning an error, passing particular values/flags to functions, …
Before:
After:
