Add support for LSP textDocument/documentHighlight #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows nord to properly handle the highlight groups associated with the method textDocument/documentHightlight in neovim.
|
Hi @cmoscofian 👋, thanks for your contribution 👍 |
The implementation of the LspReference highlight groups should not be under the 0.5 check as it was not subjected to any deprecation.
svengreb
approved these changes
Jan 12, 2022
arcticicestudio
approved these changes
Jan 12, 2022
Release note & changelog assets
gh-284.mp4 |
jcypret
pushed a commit
to jcypret/nord-vim-midnight
that referenced
this pull request
Feb 19, 2022
Support for Neovim LSP `documentHighlight` groups The Neovim LSP `textDocument` / `documentHightlight` groups [1] are responsible to highlight tokens in a document that are related to each other, e.g. decalred variables, using the `vim.buf.lsp.document_highlight()` function. Also see the LSP specification about "Document Highlights Request" [2] for more details. [1]: https://github.com/neovim/neovim/blob/f92a2457c2e7ad14d9a5a907ef4213fa770b6d95/runtime/doc/lsp.txt#L423 [2]: https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de>
crispgm
added a commit
to crispgm/nord-vim
that referenced
this pull request
Apr 2, 2022
arcticicestudio
added a commit
that referenced
this pull request
May 14, 2022
Support for Neovim LSP `documentHighlight` groups The Neovim LSP `textDocument` / `documentHightlight` groups [1] are responsible to highlight tokens in a document that are related to each other, e.g. decalred variables, using the `vim.buf.lsp.document_highlight()` function. Also see the LSP specification about "Document Highlights Request" [2] for more details. [1]: https://github.com/neovim/neovim/blob/f92a2457c2e7ad14d9a5a907ef4213fa770b6d95/runtime/doc/lsp.txt#L423 [2]: https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Co-authored-by: Sven Greb <development@svengreb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows nord to properly handle the highlight groups associated with the
method textDocument/documentHightlight in neovim.
See it in action:
