Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreadable text color on pending search result highlights #39

Merged
merged 1 commit into from Aug 3, 2017
Merged

Fix unreadable text color on pending search result highlights #39

merged 1 commit into from Aug 3, 2017

Conversation

arcticicestudio
Copy link
Contributor

@arcticicestudio arcticicestudio commented Jul 16, 2017 •
edited

Fixes #32
Must be merged before #41

Before

After

@arcticicestudio arcticicestudio added this to the 0.6.0 milestone Jul 16, 2017
This was referenced Jul 16, 2017
Closed
Merged
dylnmc
dylnmc approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@dylnmc dylnmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

syedelec
syedelec approved these changes Jul 21, 2017
View reviewed changes
Copy link

@syedelec syedelec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixed the problem, thanks !

@arcticicestudio
Copy link
Contributor Author

I'll merge this within the next days to publish the new release version. 📅

@arcticicestudio arcticicestudio merged commit ba79336 into develop Aug 3, 2017
@arcticicestudio arcticicestudio deleted the bugfix/gh-32-search-highlight-on-strings-illegible branch August 3, 2017 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylnmc dylnmc dylnmc approved these changes

@syedelec syedelec syedelec approved these changes

Assignees
No one assigned
Labels
context-syntax scope-quality type-bug
Projects
None yet
Milestone
version-0.6.0
Development

Successfully merging this pull request may close these issues.

search highlight on strings illegible
4 participants
@arcticicestudio @dylnmc @syedelec @svengreb