Adjust fold color to match comment colors

[arcticicestudio]

Closes #38

Adjusted the unreadable fold marker color to match the color of comments.

---

\cc @syedelec

[dylnmc]

much more visible folds. (:laughing: sorry. I hadn't read up on what this gh approve feature was, and I thought that maybe I should approve this, but now I have read it is for admins w/ write privileges -- sorry.)

[arcticicestudio]

Adjusted the background color to differ from normal comments. Also now using a bold font style for better legibility.

[arcticicestudio]

@dylnmc It's totally fine to use the code review feature and approve PRs. It can be used by everyone and helps the maintainer(s) a lot if users posting feedback this way. The forced review for code owners or team members is activated to allow the owner of the repository (or the specific code owner) to review, change or decline a PR before it gets merged by a another user with write privileges without the approve of the code owner.

[dylnmc]

I just spent 10 minutes messing around with different foregrounds/backgrounds. I can't find anything that I truly like. This seems like the best option. My second favorite was nord5 foreground (white) on nord1 background (lightened dark-gray) -- but I am sure this violates the low-contrast policy, also.

[syedelec]

I rarely use folds but it's better with this improvement, thanks !

[arcticicestudio]

I'll merge this within the next days to publish the new release version. 📅

[uwo]

I apologize if this question reopens the ticket. My folds are still to dark to read. I'm using let g:nord_comment_brightness = 20. If you have any advice I'd greatly appreciate it.

[dylnmc]

@uwo,

a) I use folds a lot now with foldmethod=syntax

b) I don't think that g:nord_comment_brightness is affecting the colors for folds. You can manually change them with something like the snippet below, but you're correct that they don't change the folds colors (at least I think).

---

snippet

augroup Nord
    autocmd!
    autocmd ColorScheme nord highlight Folded guifg=#616e88
augroup end

I agree and think that there should be another setting for folds (since they have a different background color and should be, therefore, brighter.

---

@arcticicestudio ever considered doing what solarized does for terminal and instead of duplicating (most of) the first 8 colors for the latter "bright" colors (you know ... 9-15, as opposed to the first half, 0-8). The concern, obviously, is that many terminals (including st .. unless you hack st.c) set bold colors to "bright" colors (eg, add 8 to the 0-8 color to transpose it to the bright version). They should not do this, and some terminals, like urxvt, one can configure to disable this stupid "feature". Once again, though I point to solarized. which does this. We could add different (and user-configurable ... the user could swap out the colors in their dotfile for their terminal ... to one of the ones in s:nord3_gui_brightened or their own even) tones of this cool gray (the background and its lighter variants) and replace some of the duplicate colors for term. Just a thought, but you'd have to weigh the pros/cons.

cheers and I still can't find a colorscheme better then yours 😈,
dylnmc

---

P.S.

I, personally, can't see anything unless I set g:nord_comment_brightness = 4 (unless I am in the dark).