Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting for Elixir module names and atoms #166

Merged
merged 2 commits into from Dec 23, 2019
Merged

Syntax highlighting for Elixir module names and atoms #166

merged 2 commits into from Dec 23, 2019

Conversation

feliperenan
Copy link
Contributor

Closes: #165

Improve Elixir support adding syntax highlight to atoms and module names using vscode-elixir-lis patterns.

References:
https://github.com/JakeBecker/vscode-elixir-ls
https://github.com/JakeBecker/vscode-elixir-ls/blob/master/syntaxes/elixir.json

@feliperenan feliperenan changed the title Improve Elixir support Add Elixir highlight for module names and atoms. Dec 1, 2019
Fix: #165

Improve Elixir support adding syntax highlight to atoms and module
names using `vscode-elixir-lis` patterns.

References:
https://github.com/JakeBecker/vscode-elixir-ls
https://github.com/JakeBecker/vscode-elixir-ls/blob/master/syntaxes/elixir.json
@feliperenan feliperenan changed the title Add Elixir highlight for module names and atoms. Add Elixir syntax highlight for module names and atoms. Dec 1, 2019
@arcticicestudio arcticicestudio self-assigned this Dec 4, 2019
@arcticicestudio arcticicestudio added this to the Next milestone Dec 4, 2019
@arcticicestudio
Copy link
Contributor

Hi @feliperenan 👋, thanks for your contribution 👍
I'll review it in the near future and get back to you.

This documents that the added scopes are only available for the specific
extension with the given ID and not supported by VSCode out-of-the-box.

GH-165
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for your contribution.
I've only added the marketplace ID of the extension to document that these scopes are not support out-of-the-box by VSCode but only for the specific extension.


Maintainer Release/Changelog Resources

Before

After

@arcticicestudio arcticicestudio changed the title Add Elixir syntax highlight for module names and atoms. Syntax highlighting for Elixir module names and atoms Dec 23, 2019
@arcticicestudio arcticicestudio merged commit 810a894 into nordtheme:develop Dec 23, 2019
@arcticicestudio arcticicestudio removed their assignment Dec 23, 2019
arcticicestudio pushed a commit that referenced this pull request Dec 23, 2019
Improved syntax highlighting for Elixir atoms and module names using
scopes provided by the JakeBecker.elixir-ls [1,2,3] extension.
The scopes also include the VSCode extension ID to document that the
added scopes are only available for the specific extension with the
given ID and not supported by VSCode out-of-the-box.

[1]: https://marketplace.visualstudio.com/items?itemName=JakeBecker.elixir-ls
[2]: https://github.com/JakeBecker/vscode-elixir-ls
[3]: https://github.com/JakeBecker/vscode-elixir-ls/blob/master/syntaxes/elixir.json

Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com>
Resolves GH-165
@feliperenan feliperenan deleted the frg-improve-elixir-support branch December 23, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elixir: Missing syntax highlight in modules and atoms
3 participants