Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated AddAutoRestartServiceBusMessagePumpOnRotatedCredentialsBackgroundJob extensions on the IServiceCollection #149

Closed
Tracked by #311
stijnmoreels opened this issue Jun 15, 2022 · 0 comments · Fixed by #210
Closed
Tracked by #311

Remove deprecated AddAutoRestartServiceBusMessagePumpOnRotatedCredentialsBackgroundJob extensions on the IServiceCollection #149

stijnmoreels opened this issue Jun 15, 2022 · 0 comments · Fixed by #210
Assignees
@stijnmoreels
Labels
az-key-vault All issues related to Azure Key Vault background jobs breaking-change All issues related to breaking changes good first issue Good for newcomers
Projects
Roadmap
Milestone
v1.0

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Jun 15, 2022 •
edited

Is your feature request related to a problem? Please describe.
Previously, we used the IServiceCollection to add all background jobs, but the 'auto restart message pump' background job has a dependency on a registered message pump, which is why we moved this background job registration to the dedicated ServiceBusMessageHandlerCollection type.

Describe the solution you'd like
Remove the deprecated AddAutoRestartServiceBusMessagePumpOnRotatedCredentialsBackgroundJob extensions on the iServiceCollection in the Arcus.BackgroundJobs.KeyVault project.
@stijnmoreels stijnmoreels added good first issue Good for newcomers az-key-vault All issues related to Azure Key Vault background jobs breaking-change All issues related to breaking changes labels Jun 15, 2022
@stijnmoreels stijnmoreels added this to the v1.0 milestone Jun 15, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Jun 15, 2022
@stijnmoreels stijnmoreels changed the title Remove deprecated AddAutoRestartServiceBusMessagePumpOnRotatedCredentialsBackgroundJob extension on the IServiceCollection Remove deprecated AddAutoRestartServiceBusMessagePumpOnRotatedCredentialsBackgroundJob extensions on the IServiceCollection Jun 15, 2022
@stijnmoreels stijnmoreels mentioned this issue Dec 15, 2023
Open
48 tasks
@stijnmoreels stijnmoreels self-assigned this Feb 2, 2024
@stijnmoreels stijnmoreels mentioned this issue Feb 2, 2024
Merged
Roadmap automation moved this from To do to Done Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
az-key-vault All issues related to Azure Key Vault background jobs breaking-change All issues related to breaking changes good first issue Good for newcomers
Projects
Roadmap
  
Done
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

chore: remove deprecated functionality arcus-azure/arcus.backgroundjobs
1 participant
@stijnmoreels