Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ServiceBusEntity enumeration #235

Closed
Tracked by #311
stijnmoreels opened this issue Feb 3, 2022 · 0 comments · Fixed by #430
Closed
Tracked by #311

Remove the ServiceBusEntity enumeration #235

stijnmoreels opened this issue Feb 3, 2022 · 0 comments · Fixed by #430
Assignees
@fgheysels
Labels
breaking-change All issues related to code breaking changes. good first issue Good for newcomers message-pumps All issues related to message pumps
Projects
Roadmap
Milestone
v2.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
When creating Azure Service Bus message pumps, we had to determine for which entity type the message pump was created. We added a ServiceBusEntity enumeration to make this distinction. Later, we chose to use the built-in ServiceBusEntityType enumeration, making this one obsolete.

Describe the solution you'd like
Remove the ServiceBusEntity enumeration.
@stijnmoreels stijnmoreels added breaking-change All issues related to code breaking changes. message-pumps All issues related to message pumps labels Feb 3, 2022
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Feb 3, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Feb 3, 2022
@stijnmoreels stijnmoreels added the good first issue Good for newcomers label Feb 3, 2022
@stijnmoreels stijnmoreels mentioned this issue Dec 15, 2023
Open
48 tasks
@fgheysels fgheysels self-assigned this Dec 15, 2023
@fgheysels fgheysels mentioned this issue Dec 15, 2023
Merged
Roadmap automation moved this from To do to Done Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgheysels fgheysels

Labels
breaking-change All issues related to code breaking changes. good first issue Good for newcomers message-pumps All issues related to message pumps
Projects
Roadmap
  
Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

chore: Remove ServiceBusEntity enumeration arcus-azure/arcus.messaging
2 participants
@fgheysels @stijnmoreels